[dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command

Min Hu (Connor) humin29 at huawei.com
Thu Oct 8 12:06:59 CEST 2020


Hi, Ferruh,
	I have sent patches of new version named V16. Please check it
out, thanks.

在 2020/10/8 7:38, humin (Q) 写道:
> HI,Ferry,
> 
>       thank you very much. this is good news to me. I promise the new 
> version will be sent in these two days.
> 
>        thanks again.
> 
> --------------------------------------------------
> 胡敏 Hu Min
> Mobile: +86-13528728164 <tel:+86-13528728164>
> Email: humin29 at huawei.com <mailto:humin29 at huawei.com>
> 
> *发件人:*Ferruh Yigit <ferruh.yigit at intel.com>
> *收件人:*humin (Q) <humin29 at huawei.com>;dev <dev at dpdk.org>
> *抄 送:*konstantin.ananyev <konstantin.ananyev at intel.com>;thomas 
> <thomas at monjalon.net>;arybchenko <arybchenko at solarflare.com>;Linuxarm 
> <linuxarm at huawei.com>
> *时 间:*2020-10-07 17:30:09
> *主 题:*Re: [PATCH V15 3/3] app/testpmd: add FEC command
> 
> On 10/7/2020 1:15 AM, humin (Q) wrote:
>> HI,Ferruh,
>> 
>>       how about only considering the first patch:ethdev:add fec API. If this 
>> patch looks great to you, I wish it could be merged into 20.11.
>> 
>>        To that patch, app/testpmd add fec command, I will fix it later.
> 
> Hi Connor,
> 
> Better to get them together if possible, -rc1 has been postponed to 
> October 16,
> can this additional week help to get a new version?
> 
> 
>> 
>>        thanks.
>> 
>> --------------------------------------------------
>> 胡敏 Hu Min
>> Mobile: +86-13528728164 <tel:+86-13528728164>
>> Email: humin29 at huawei.com <mailto:humin29 at huawei.com>
>> 
>> *发件人:*Ferruh Yigit <ferruh.yigit at intel.com>
>> *收件人:*humin (Q) <humin29 at huawei.com>;dev <dev at dpdk.org>
>> *抄 送:*konstantin.ananyev <konstantin.ananyev at intel.com>;thomas 
>> <thomas at monjalon.net>;arybchenko <arybchenko at solarflare.com>;Linuxarm 
>> <linuxarm at huawei.com>
>> *时 间:*2020-10-01 00:53:37
>> *主 题:*Re: [PATCH V15 3/3] app/testpmd: add FEC command
>> 
>> On 9/29/2020 2:03 AM, Min Hu (Connor) wrote:
>>> This commit adds testpmd capability to query and config FEC
>>> function of device. This includes:
>>> - show FEC capabilities, example:
>>>        testpmd> show port 0 fec capabilities
>>> - show FEC mode, example:
>>>        testpmd> show port 0 fec_mode
>>> - config FEC mode, example:
>>>        testpmd> set port <port_id> 0 <auto|off|rs|baser>
>>> 
>> 
>> I guess it is:
>> set port <port_id> fec_mode <auto|off|rs|baser>
>> 
>>>        where:
>>> 
>>>        auto|off|rs|baser are four kinds of FEC mode which dev
>>>        support according to MAC link speed.
>>> 
>>> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
>>> Reviewed-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>>> Reviewed-by: Chengwen Feng <fengchengwen at huawei.com>
>>> Reviewed-by: Chengchang Tang <tangchengchang at huawei.com>
>>> ---
>>> v12->v13:
>>> change fec get capa interface.
>>> 
>>> ---
>>> v10->v11:
>>> change mode to capa bitmask.
>>> 
>>> ---
>>> v8->v9:
>>> added acked-by.
>>> 
>>> ---
>>> v6->v7:
>>> used RTE_DIM(fec_mode_name) instead of RTE_ETH_FEC_NUM
>>> 
>>> ---
>>> v5->v6:
>>> fixed code styles according to DPDK coding style.
>>> added _eth prefix.
>>> 
>>> ---
>>> v4->v5:
>>> Add RTE_ prefix for public FEC mode enum.
>>> 
>>> ---
>>> v3->v4:
>>> adjust the display format of FEC mode
>>> 
>>> ---
>>> v2->v3:
>>> adjust the display format of FEC capability.
>>> 
>>> ---
>>>   app/test-pmd/cmdline.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++
>>>   app/test-pmd/config.c  |  91 ++++++++++++++++++++
>>>   app/test-pmd/testpmd.h |   2 +
>>>   3 files changed, 316 insertions(+)
>> 
>> Can you please update the testpmd documenatation for the new commands?
>> 
>> Also can add the new command to the --help output? ('cmd_help_long_parsed()')
>> 
>> <...>
>> 
>>> +cmdline_parse_inst_t cmd_set_fec_mode = {
>>> +     .f = cmd_set_port_fec_mode_parsed,
>>> +     .data = NULL,
>>> +     .help_str = "set port <port_id> fec_mode <auto|off|rs|baser>",
>> 
>> Can you please update the help string as:
>> "set port <port_id> fec_mode auto|off|rs|baser"
>> 
>> '<>' is to define the variable name, like in '<port_id>' you expect numbers like
>> 0,1,2 .. but 'auto|off|rs|baser' are keywords, not variables.
> 
> 
> _______________________________________________
> Linuxarm mailing list
> Linuxarm at huawei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
> 


More information about the dev mailing list