[dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators
Akhil Goyal
akhil.goyal at nxp.com
Thu Oct 8 21:58:05 CEST 2020
> diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
> b/lib/librte_cryptodev/rte_crypto_sym.h
> index f29c98051..7a2556a9e 100644
> --- a/lib/librte_cryptodev/rte_crypto_sym.h
> +++ b/lib/librte_cryptodev/rte_crypto_sym.h
> @@ -132,15 +132,12 @@ enum rte_crypto_cipher_algorithm {
> * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
> */
>
> - RTE_CRYPTO_CIPHER_DES_DOCSISBPI,
> + RTE_CRYPTO_CIPHER_DES_DOCSISBPI
> /**< DES algorithm using modes required by
> * DOCSIS Baseline Privacy Plus Spec.
> * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next
> * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
> */
> -
> - RTE_CRYPTO_CIPHER_LIST_END
> -
> };
Probably we should add a comment for each of the enums that we change,
that the user can define its own LIST_END = last item in the enum +1.
LIST_END is not added to avoid ABI breakage across releases when new algos
are added.
>
> /** Cipher algorithm name strings */
> @@ -312,10 +309,8 @@ enum rte_crypto_auth_algorithm {
> /**< HMAC using 384 bit SHA3 algorithm. */
> RTE_CRYPTO_AUTH_SHA3_512,
> /**< 512 bit SHA3 algorithm. */
> - RTE_CRYPTO_AUTH_SHA3_512_HMAC,
> + RTE_CRYPTO_AUTH_SHA3_512_HMAC
> /**< HMAC using 512 bit SHA3 algorithm. */
> -
> - RTE_CRYPTO_AUTH_LIST_END
> };
>
> /** Authentication algorithm name strings */
> @@ -412,9 +407,8 @@ enum rte_crypto_aead_algorithm {
> /**< AES algorithm in CCM mode. */
> RTE_CRYPTO_AEAD_AES_GCM,
> /**< AES algorithm in GCM mode. */
> - RTE_CRYPTO_AEAD_CHACHA20_POLY1305,
> + RTE_CRYPTO_AEAD_CHACHA20_POLY1305
> /**< Chacha20 cipher with poly1305 authenticator */
> - RTE_CRYPTO_AEAD_LIST_END
> };
>
> /** AEAD algorithm name strings */
> --
> 2.17.1
More information about the dev
mailing list