[dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

David Marchand david.marchand at redhat.com
Fri Oct 9 11:02:15 CEST 2020


On Fri, Oct 9, 2020 at 10:36 AM Pattan, Reshma <reshma.pattan at intel.com> wrote:
> > >> +* ethdev: Renamed basic statistics per queue. An underscore is
> > >> +inserted
> > >> +  between the queue number and the rest of the xstat name:
> > >> +
> > >> +  * ``rx_qN*`` -> ``rx_qN_*``
> > >> +  * ``tx_qN*`` -> ``tx_qN_*``
> > >> +
> > >
> > >As far as I remember collect plugin was using xstat output, does this
> > >rename affects it? Or any other telemetry application relying on xstats.
> > >
> > >Harry, Ciara, Kevin, do you know anything that will be affected from rename?
> >
> > I don't think this change will affect anything with telemetry itself, but I am not
> > so familiar with the CollectD plugin, Reshma may be able to verify that.
>
> Neither collectd has any dependency on naming.

I am not sure about this statement.
collectd dpdkstats plugin does seem to inspect the names.

And I can see what looks like a workaround on the problem Thomas is fixing here.
https://github.com/collectd/collectd/commit/126b35ee8786a3aca1bcc1346a60bc528d06c414


Can you test Thomas patch?


-- 
David Marchand



More information about the dev mailing list