[dpdk-dev] [EXT] [PATCH v6 03/14] doc: remove references to make from NICs guides
Igor Russkikh
irusskikh at marvell.com
Fri Oct 9 14:00:41 CEST 2020
Hi Ciara,
Thanks for the patch,
> --- a/doc/guides/nics/atlantic.rst
> +++ b/doc/guides/nics/atlantic.rst
> @@ -26,10 +26,6 @@ Experimental API features
>
> - MACSEC PMD API is considered as experimental and is subject to
> change/removal in next DPDK releases.
>
> -Configuration Information
> -^^^^^^^^^^^^^^^^^^^^^^^^^
> -
> -- ``CONFIG_RTE_LIBRTE_ATLANTIC_PMD`` (default ``y``)
>
> Application Programming Interface
> ---------------------------------
For atlantic,
Reviewed-by: Igor Russkikh <irusskikh at marvell.com>
> diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst
> index e874915c2f..32eede5da4 100644
> --- a/doc/guides/nics/qede.rst
> +++ b/doc/guides/nics/qede.rst
> @@ -106,22 +106,9 @@ Performance note
> Config File Options
> ~~~~~~~~~~~~~~~~~~~
>
> -The following options can be modified in the ``.config`` file. Please note
> that
> -enabling debugging options may affect system performance.
> +The following option can be modified in the ``config/rte_config.h`` file.
>
> -- ``CONFIG_RTE_LIBRTE_QEDE_PMD`` (default **y**)
> -
> - Toggle compilation of QEDE PMD driver.
This one is correctly removed, but the below defines,
> -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**)
> -
> - Toggle display of transmit fast path run-time messages.
> -
> -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX`` (default **n**)
> -
> - Toggle display of receive fast path run-time messages.
> -
> -- ``CONFIG_RTE_LIBRTE_QEDE_FW`` (default **""**)
> +- ``RTE_LIBRTE_QEDE_FW`` (default **""**)
>
> Gives absolute path of firmware file.
> ``Eg: "/lib/firmware/qed/qed_init_values-8.40.33.0.bin"``
These all still exist. I believe "CONFIG_" prefix should be removed here, but
the defines and code behind them should stay.
Regards,
Igor
More information about the dev
mailing list