[dpdk-dev] [dpdk-stable] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
Thomas Monjalon
thomas at monjalon.net
Sun Oct 11 22:06:06 CEST 2020
> > This issue detected by coverity, CID#279443(Structurally dead code).
> >
> > Coverity issue: 279443
> > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> > ---
> > --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> > +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> > @@ -452,9 +452,10 @@ rte_qdma_reset(void)
> > /* In case there are pending jobs on any VQ, return -EBUSY */
> > for (i = 0; i < qdma_dev.max_vqs; i++) {
> > if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> > - qdma_vqs[i].num_dequeues))
> > + qdma_vqs[i].num_dequeues)) {
> > DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d",
> > i);
> > return -EBUSY;
> > + }
> > }
Acked by: Nipun Gupta <nipun.gupta at nxp.com>
I don't understand how it could work before in simplest case.
Changed title to "fix reset".
Applied, thanks
More information about the dev
mailing list