[dpdk-dev] [PATCH v2 2/4] regex/octeontx2: add build infra and device support

[Thomas Monjalon]

12/10/2020 13:31, guyk at marvell.com:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1118,6 +1118,9 @@ F: drivers/regex/mlx5/
>  F: doc/guides/regexdevs/mlx5.rst
>  F: doc/guides/regexdevs/features/mlx5.ini
>  
> +Marvell OCTEON TX2 regex
> +M: Guy Kaneti <guyk at marvell.com>
> +F: drivers/regex/octeontx2/
>  

A blank line is missing.
Please sort in alphabetical order.

> --- /dev/null
> +++ b/drivers/regex/octeontx2/rte_pmd_octeontx2_regex_version.map
> @@ -0,0 +1,3 @@
> +DPDK_20.08 {
> +	local: *;
> +};

Should be DPDK_21

> --- a/meson_options.txt
> +++ b/meson_options.txt
> +option('ree_compiler_sdk', type: 'string', value: '',
> +	description: 'path to REE compiler SDK optional library for regex device')

Is this SDK specific to Marvell or octeontx2?
If yes, it should appear here.

Why this SDK requires setting the path manually?
Well designed libs should use pkg-config.