[dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats

Wang, Haiyue haiyue.wang at intel.com
Wed Oct 14 10:40:10 CEST 2020


> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit at intel.com>
> Sent: Wednesday, October 14, 2020 10:27
> To: Yigit, Ferruh <ferruh.yigit at intel.com>; John W. Linville <linville at tuxdriver.com>; Loftus, Ciara
> <ciara.loftus at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>; Shepard Siegel
> <shepard.siegel at atomicrules.com>; Ed Czeck <ed.czeck at atomicrules.com>; John Miller
> <john.miller at atomicrules.com>; Igor Russkikh <igor.russkikh at aquantia.com>; Pavel Belous
> <pavel.belous at aquantia.com>; Steven Webster <steven.webster at windriver.com>; Matt Peters
> <matt.peters at windriver.com>; Somalapuram Amaranath <asomalap at amd.com>; Rasesh Mody <rmody at marvell.com>;
> Shahed Shaikh <shshaikh at marvell.com>; Ajit Khaparde <ajit.khaparde at broadcom.com>; Somnath Kotur
> <somnath.kotur at broadcom.com>; Chas Williams <chas3 at att.com>; Min Hu (Connor) <humin29 at huawei.com>;
> Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>; Hemant Agrawal <hemant.agrawal at nxp.com>; Sachin
> Saxena <sachin.saxena at oss.nxp.com>; Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>;
> Marcin Wojtas <mw at semihalf.com>; Michal Krawczyk <mk at semihalf.com>; Guy Tzalik <gtzalik at amazon.com>;
> Evgeny Schemeilin <evgenys at amazon.com>; Igor Chauskin <igorch at amazon.com>; Gagandeep Singh
> <g.singh at nxp.com>; John Daley <johndale at cisco.com>; Hyong Youb Kim <hyonkim at cisco.com>; Gaetan Rivet
> <grive at u256.net>; Wang, Xiao W <xiao.w.wang at intel.com>; Ziyang Xuan <xuanziyang2 at huawei.com>; Xiaoyun
> Wang <cloud.wangxiaoyun at huawei.com>; Guoyang Zhou <zhouguoyang at huawei.com>; Wei Hu (Xavier)
> <xavier.huwei at huawei.com>; Yisen Zhuang <yisen.zhuang at huawei.com>; Xing, Beilei
> <beilei.xing at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Yang, Qiming <qiming.yang at intel.com>;
> Alfredo Cardigliano <cardigliano at ntop.org>; Xu, Rosen <rosen.xu at intel.com>; Shijith Thotton
> <sthotton at marvell.com>; Srisivasubramanian Srinivasan <srinivasan at marvell.com>; Jakub Grajciar
> <jgrajcia at cisco.com>; Matan Azrad <matan at nvidia.com>; Shahaf Shuler <shahafs at nvidia.com>; Viacheslav
> Ovsiienko <viacheslavo at nvidia.com>; Zyta Szpak <zr at semihalf.com>; Liron Himi <lironh at marvell.com>;
> Stephen Hemminger <sthemmin at microsoft.com>; K. Y. Srinivasan <kys at microsoft.com>; Haiyang Zhang
> <haiyangz at microsoft.com>; Long Li <longli at microsoft.com>; Martin Spinler <spinler at cesnet.cz>; Heinrich
> Kuhn <heinrich.kuhn at netronome.com>; Tetsuya Mukawa <mtetsuyah at gmail.com>; Harman Kalra
> <hkalra at marvell.com>; Jerin Jacob <jerinj at marvell.com>; Nithin Dabilpuram <ndabilpuram at marvell.com>;
> Kiran Kumar K <kirankumark at marvell.com>; Akhil Goyal <akhil.goyal at nxp.com>; Richardson, Bruce
> <bruce.richardson at intel.com>; Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>; Wiles, Keith
> <keith.wiles at intel.com>; Maciej Czekaj <mczekaj at marvell.com>; Maxime Coquelin
> <maxime.coquelin at redhat.com>; Xia, Chenbo <chenbo.xia at intel.com>; Wang, Zhihong
> <zhihong.wang at intel.com>; Yong Wang <yongwang at vmware.com>; Thomas Monjalon <thomas at monjalon.net>
> Cc: dev at dpdk.org
> Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
> 
> Queue stats are stored in 'struct rte_eth_stats' as array and array size
> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.
> 
> As a result of technical board discussion, decided to remove the queue
> statistics from 'struct rte_eth_stats' in the long term.
> 
> Instead PMDs should represent the queue statistics via xstats, this
> gives more flexibility on the number of the queues supported.
> 
> Currently queue stats in the xstats are filled by ethdev layer, using
> some basic stats, when queue stats removed from basic stats the
> responsibility to fill the relevant xstats will be pushed to the PMDs.
> 
> During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS'
> device flag is created. Initially all PMDs using xstats set this flag.
> The PMDs implemented queue stats in the xstats should clear the flag.
> 
> When all PMDs switch to the xstats for the queue stats, queue stats
> related fields from 'struct rte_eth_stats' will be removed, as well as
> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
> Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be
> removed.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---


>  drivers/net/e1000/em_ethdev.c             |  1 +
>  drivers/net/e1000/igb_ethdev.c            |  2 ++
>  drivers/net/igc/igc_ethdev.c              |  1 +
>  drivers/net/ixgbe/ixgbe_ethdev.c          |  2 ++

For e1000, igc, ixgbe PMDs,
Acked-by: Haiyue Wang <haiyue.wang at intel.com>

>  /**
>   * Iterates over valid ethdev ports owned by a specific owner.
> --
> 2.26.2



More information about the dev mailing list