[dpdk-dev] [PATCH v5 04/10] ethdev: add simple power management API

Bruce Richardson bruce.richardson at intel.com
Wed Oct 14 11:23:38 CEST 2020


On Wed, Oct 14, 2020 at 10:07:09AM +0100, Burakov, Anatoly wrote:
> On 14-Oct-20 4:10 AM, Guo, Jia wrote:
> > 
> > > -----Original Message-----
> > > From: dev <dev-bounces at dpdk.org> On Behalf Of Anatoly Burakov
> > > Sent: Saturday, October 10, 2020 12:02 AM
> > > To: dev at dpdk.org
> > > Cc: Ma, Liang J <liang.j.ma at intel.com>; Thomas Monjalon
> > > <thomas at monjalon.net>; Yigit, Ferruh <ferruh.yigit at intel.com>; Andrew
> > > Rybchenko <andrew.rybchenko at oktetlabs.ru>; Ray Kinsella
> > > <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>; Hunt, David
> > > <david.hunt at intel.com>; Ananyev, Konstantin
> > > <konstantin.ananyev at intel.com>; jerinjacobk at gmail.com; Richardson,
> > > Bruce <bruce.richardson at intel.com>; McDaniel, Timothy
> > > <timothy.mcdaniel at intel.com>; Eads, Gage <gage.eads at intel.com>;
> > > Macnamara, Chris <chris.macnamara at intel.com>
> > > Subject: [dpdk-dev] [PATCH v5 04/10] ethdev: add simple power
> > > management API
> > > 
> > > From: Liang Ma <liang.j.ma at intel.com>
> > > 
> > > Add a simple API to allow getting address of next RX descriptor from the
> > > PMD, as well as release notes information.
> > > 
> > > Signed-off-by: Liang Ma <liang.j.ma at intel.com>
> > > Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > > ---
> 
> Hi Jia,
> 
> Thanks for your review. Responses below.
> 
> > > 
> > > Notes:
> > >      v5:
> > >      - Bring function format in line with other functions in the file
> > >      - Ensure the API is supported by the driver before calling it (Konstantin)
> > > 
> > >   doc/guides/rel_notes/release_20_11.rst   | 16 ++++++++++++++
> > >   lib/librte_ethdev/rte_ethdev.c           | 17 ++++++++++++++
> > >   lib/librte_ethdev/rte_ethdev.h           | 24 ++++++++++++++++++++
> > >   lib/librte_ethdev/rte_ethdev_driver.h    | 28 ++++++++++++++++++++++++
> > >   lib/librte_ethdev/rte_ethdev_version.map |  1 +
> > >   5 files changed, 86 insertions(+)
> > > 
> > > diff --git a/doc/guides/rel_notes/release_20_11.rst
> > > b/doc/guides/rel_notes/release_20_11.rst
> > > index 808bdc4e54..e85af5d3e9 100644
> > > --- a/doc/guides/rel_notes/release_20_11.rst
> > > +++ b/doc/guides/rel_notes/release_20_11.rst
> > > @@ -55,6 +55,11 @@ New Features
> > >        Also, make sure to start the actual text at the margin.
> > >        =======================================================
> > > 
> > > +* **ethdev: add 1 new EXPERIMENTAL API for PMD power
> > > management.**
> > > +
> > > +  * ``rte_eth_get_wake_addr()``
> > > +  * add new eth_dev_ops ``get_wake_addr``
> > > +
> > >   * **Updated Broadcom bnxt driver.**
> > > 
> > >     Updated the Broadcom bnxt driver with new features and improvements,
> > > including:
> > > @@ -136,6 +141,17 @@ New Features
> > >     * Extern objects and functions can be plugged into the pipeline.
> > >     * Transaction-oriented table updates.
> > > 
> > > +* **Add PMD power management mechanism**
> > > +
> > > +  3 new Ethernet PMD power management mechanism is added through
> > 
> > " mechanisms are " please.
> > 
> > > + existing  RX callback infrastructure.
> > > +
> > > +  * Add power saving scheme based on UMWAIT instruction (x86 only)
> > > +  * Add power saving scheme based on ``rte_pause()``
> > > +  * Add power saving scheme based on frequency scaling through the
> > > + power library
> > > +  * Add new EXPERIMENTAL API
> > > ``rte_power_pmd_mgmt_queue_enable()``
> > > +  * Add new EXPERIMENTAL API
> > > ``rte_power_pmd_mgmt_queue_disable()``
> > > +
> > 
> > Could this doc be separate to other specific patch if it is not related with this patch?
> 
> It is related - it's the doc changes that add mention of this API. I was
> under the impression current policy was having doc updates in the same patch
> as the changes made?
> 

Yes, that is the case. Doc changes should be made alongside the relevant
code changes.


More information about the dev mailing list