[dpdk-dev] [PATCH v3 27/56] net/txgbe: fill receive functions

[Ferruh Yigit]

On 10/14/2020 6:54 AM, Jiawen Wu wrote:
> Fill receive functions and define receive descriptor.
> 
> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>

<...>

> @@ -42,6 +54,17 @@ static const u64 TXGBE_TX_OFFLOAD_MASK = (PKT_TX_IP_CKSUM |
>   #define TXGBE_TX_OFFLOAD_NOTSUP_MASK \
>   		(PKT_TX_OFFLOAD_MASK ^ TXGBE_TX_OFFLOAD_MASK)
>   
> +#define RTE_PMD_USE_PREFETCH
> +
> +#ifdef RTE_PMD_USE_PREFETCH
> +/*
> + * Prefetch a cache line into all cache levels.
> + */
> +#define rte_txgbe_prefetch(p)   rte_prefetch0(p)
> +#else
> +#define rte_txgbe_prefetch(p)   do {} while (0)
> +#endif

If 'RTE_PMD_USE_PREFETCH' will be always defined, can it be removed?

<...>

> @@ -145,6 +239,12 @@ struct txgbe_tx_desc {
>   #define RX_RING_SZ ((TXGBE_RING_DESC_MAX + RTE_PMD_TXGBE_RX_MAX_BURST) * \
>   		    sizeof(struct txgbe_rx_desc))
>   
> +#ifdef RTE_PMD_PACKET_PREFETCH
> +#define rte_packet_prefetch(p)  rte_prefetch1(p)
> +#else
> +#define rte_packet_prefetch(p)  do {} while (0)
> +#endif

Since there is no config file we had in the Makebuild times, can you please 
document all the compile time flags that the driver is using, in the driver 
documentation, as they are introduced.
And showing how can they be enabled via meson (meson 
-Dc_args="-DRTE_PMD_PACKET_PREFETCH" ... )