[dpdk-dev] [PATCH] test/telemetry: fix socket resource leak

[Kevin Laatz]

On 13/10/2020 16:56, Ciara Power wrote:
> If an error occurred when reading from the socket, the function
> returned without closing the socket. This is now fixed to avoid the
> resource leak of the sock variable going out of scope.
>
> Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON")
> Coverity issue: 363043
>
> Signed-off-by: Ciara Power <ciara.power at intel.com>
> ---
>   app/test/test_telemetry_data.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c
> index 7a31e68a78..f3807a7255 100644
> --- a/app/test/test_telemetry_data.c
> +++ b/app/test/test_telemetry_data.c
> @@ -327,6 +327,7 @@ connect_to_socket(void)
>   	if (bytes < 0) {
>   		printf("%s: Error with socket read - %s\n", __func__,
>   				strerror(errno));
> +		close(sock);
>   		return -1;
>   	}
>   	buf[bytes] = '\0';


Acked-by: Kevin Laatz <kevin.laatz at intel.com>