[dpdk-dev] [EXT] Re: [PATCH v1] regexdev: add OOS capability definition

Ori Kam orika at nvidia.com
Wed Oct 21 09:15:17 CEST 2020


Hi

> -----Original Message-----
> From: Guy Kaneti <guyk at marvell.com>
> Sent: Tuesday, October 20, 2020 5:24 PM
> Subject: RE: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability
> definition
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas at monjalon.net>
> > Sent: Tuesday, October 20, 2020 3:37 PM
> > To: Guy Kaneti <guyk at marvell.com>
> > Cc: orika at nvidia.com; dev at dpdk.org; Smadar Fuks
> > <smadarf at marvell.com>; Dovrat Zifroni <dovrat at marvell.com>; Jerin Jacob
> > Kollanukkaran <jerinj at marvell.com>
> > Subject: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability
> > definition
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > 20/10/2020 10:16, guyk at marvell.com:
> > > From: Guy Kaneti <guyk at marvell.com>
> > >
> > > Add out of order scan capability to check PMD support for OOS.
> > >
> > > Signed-off-by: Guy Kaneti <guyk at marvell.com>
> > > ---
> > > --- a/lib/librte_regexdev/rte_regexdev.h
> > > +++ b/lib/librte_regexdev/rte_regexdev.h
> > > +#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22) /**<
> > RegEx
> > > +device support out of order scan, this means the scan can be retired
> >
> > s/support/supports/
> 
> I followed the other RTE_REGEXDEV_CAPA_ definitions
> I can fix it here
> 
> >
> > What means "retired"?
> 
> This was the original description in the rte_regexdev.h:
> 
> #define RTE_REGEX_QUEUE_PAIR_CFG_OOS_F (1ULL << 0)
> /**< Out of order scan, If not set, a scan must retire after previously issued
>  * in-order scans to this queue pair. If set, this scan can be retired as soon
>  * as device returns completion. Application should not set out of order scan
>  * flag if it needs to maintain the ingress order of scan request.
> 
I agree with Thomas, it is not very clear, The idea was to show that a scan can return a result
>From newer job/search on a specific queue before a previous job on the same queue is completed.

Best,
Ori

> >
> > > + * as soon as device returns completion.
> > > + *
> > > + * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
> > > + * @see struct rte_regexdev_info::regexdev_capa */
> >
> >



More information about the dev mailing list