[dpdk-dev] [PATCH v6 4/5] app/test: use new allowlist and blocklist
David Marchand
david.marchand at redhat.com
Sun Oct 25 19:47:16 CET 2020
On Sun, Oct 25, 2020 at 5:59 PM Stephen Hemminger
<stephen at networkplumber.org> wrote:
> @@ -61,7 +61,7 @@ do_recursive_call(void)
> { "test_main_lcore_flag", no_action },
> { "test_invalid_n_flag", no_action },
> { "test_no_hpet_flag", no_action },
> - { "test_whitelist_flag", no_action },
> + { "test_allowlist_flag", no_action },
"test_allow_flag"
This is the reason for the current CI UT failure.
> { "test_invalid_b_flag", no_action },
> { "test_invalid_vdev_flag", no_action },
> { "test_invalid_r_flag", no_action },
[snip]
> @@ -1492,9 +1492,9 @@ test_eal_flags(void)
> return ret;
> }
>
> - ret = test_whitelist_flag();
> + ret = test_allow_flag();
> if (ret < 0) {
> - printf("Error in test_invalid_whitelist_flag()\n");
> + printf("Error in test_invalid_allow_flag()\n");
printf("Error in test_allow_flag()\n");
> return ret;
> }
>
While at it.
As far as patch 3 of this series is concerned, you can probably look
again at the comments I made on v1 (no need for a -B short option
introduction).
Plus, mix of tabs/spaces, mix of allow-block/include-exclude, in the
comments, usage() strings, plus hardcoded strings rather than use of
"--" OPT_XXX.
--
David Marchand
More information about the dev
mailing list