[dpdk-dev] [PATCH 1/2] net/txgbe: fix driver exit
Ferruh Yigit
ferruh.yigit at intel.com
Tue Oct 27 11:53:33 CET 2020
On 10/27/2020 6:24 AM, Jiawen Wu wrote:
> Replace the 'rte_panic()' with an error return.
> Also change the type of the calling function.
>
> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
> ---
> drivers/net/txgbe/txgbe_ethdev.h | 2 +-
> drivers/net/txgbe/txgbe_pf.c | 12 ++++++++----
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h
> index b708e6d43..fb1368890 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.h
> +++ b/drivers/net/txgbe/txgbe_ethdev.h
> @@ -290,7 +290,7 @@ void txgbe_configure_dcb(struct rte_eth_dev *dev);
> int
> txgbe_dev_link_update_share(struct rte_eth_dev *dev,
> int wait_to_complete);
> -void txgbe_pf_host_init(struct rte_eth_dev *eth_dev);
> +int txgbe_pf_host_init(struct rte_eth_dev *eth_dev);
Better to update where 'txgbe_pf_host_init()' is called and check the return type.
Can you please check the following patch as sample:
https://patches.dpdk.org/patch/81576/
More information about the dev
mailing list