[dpdk-dev] [PATCH] examples/fips_validation: fix resource leak on failure

Ciara Power ciara.power at intel.com
Wed Oct 28 16:53:27 CET 2020


The dst variable went out of scope on failure in the get_writeback_data
function. This is now freed before returning -1.

Coverity issue: 363453
Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")
Cc: roy.fan.zhang at intel.com

Signed-off-by: Ciara Power <ciara.power at intel.com>
---
 examples/fips_validation/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 07532c9562..be38eb29b6 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1128,6 +1128,7 @@ get_writeback_data(struct fips_val *val)
 
 	if (data_len) {
 		RTE_LOG(ERR, USER1, "Error -1: write back data\n");
+		free(dst);
 		return -1;
 	}
 
-- 
2.25.1



More information about the dev mailing list