[dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue

[Ferruh Yigit]

On 10/30/2020 5:32 AM, Zhang, Yuying wrote:
> 
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> Sent: Friday, October 23, 2020 6:42 PM
>> To: Zhang, Yuying <yuying.zhang at intel.com>; dev at dpdk.org; Zhang, Qi Z
>> <qi.z.zhang at intel.com>; Xing, Beilei <beilei.xing at intel.com>
>> Cc: stable at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue
>>
>> On 10/19/2020 3:20 AM, Yuying Zhang wrote:
>>> i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual
>>> channel commands safely in multi-process mode and multi-thread mode.
>>> However, it returns -1 when one process or thread is pending. Add
>>> rte_spinlock_trylock() to handle this issue in concurrent scenarios.
>>>
>>
>> Should '_atomic_set_cmd()' removed, since spinlock it added?
>>
>>> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>>> Cc: stable at dpdk.org
>>>
>>> Signed-off-by: Yuying Zhang <yuying.zhang at intel.com>
>>
>> <...>
> '_atomic_set_cmd()' is also used for sync with i40evf_handle_aq_msg to handle the request <-> response.
> It is not just used for multi-task. I prefer to keep the atomic.
> 

OK