[dpdk-dev] [PATCH v8 17/23] event/dlb2: add enqueue and its burst variants

McDaniel, Timothy timothy.mcdaniel at intel.com
Sat Oct 31 18:13:12 CET 2020



> -----Original Message-----
> From: Jerin Jacob <jerinjacobk at gmail.com>
> Sent: Saturday, October 31, 2020 4:52 AM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Cc: dpdk-dev <dev at dpdk.org>; Carrillo, Erik G <Erik.G.Carrillo at intel.com>;
> Eads, Gage <gage.eads at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Jerin Jacob <jerinj at marvell.com>; Thomas
> Monjalon <thomas at monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH v8 17/23] event/dlb2: add enqueue and its burst
> variants
> 
> On Sat, Oct 31, 2020 at 7:36 AM Timothy McDaniel
> <timothy.mcdaniel at intel.com> wrote:
> >
> > Add support for enqueue and its variants.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> > Reviewed-by: Gage Eads <gage.eads at intel.com>
> > ---
> >  doc/guides/eventdevs/dlb2.rst | 118 +++++++++
> >  drivers/event/dlb2/dlb2.c     | 578
> ++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 696 insertions(+)
> 
> 
> 
> Found following build error at this patch with clang
> 
> [2262/2494] Linking target drivers/librte_bus_vmbus.so.21.0
> [2263/2494] Compiling C object
> drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_dlb2.c.o
> FAILED: drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_dlb2.c.o
> ccache clang -Idrivers/libtmp_rte_event_dlb2.a.p -Idrivers
> -I../drivers -Idrivers/event/dlb2 -I../drivers/event/dlb2
> -Ilib/librte_eventdev -I../lib/librte_eventdev -I. -I.. -Iconfig
> -I../config -Ilib/librte_eal/include -I../lib/librte_eal/i
> nclude -Ilib/librte_eal/linux/include
> -I../lib/librte_eal/linux/include -Ilib/librte_eal/x86/include
> -I../lib/librte_eal/x86/include -Ilib/librte_eal/common
> -I../lib/librte_eal/common -Ilib/librte_eal -I../lib/librte_eal
> -Ilib/librte_kvargs
>  -I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics
> -Ilib/librte_telemetry -I../lib/librte_telemetry -Ilib/librte_ring
> -I../lib/librte_ring -Ilib/librte_ethdev -I../lib/librte_ethdev
> -Ilib/librte_net -I../lib/librte_net -Il
> ib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool
> -I../lib/librte_mempool -Ilib/librte_meter -I../lib/librte_meter
> -Ilib/librte_hash -I../lib/librte_hash -Ilib/librte_rcu
> -I../lib/librte_rcu -Ilib/librte_timer -I../lib/librte_timer -
> Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_pci
> -I../lib/librte_pci -Idrivers/bus/pci -I../drivers/bus/pci
> -I../drivers/bus/pci/linux -Xclang -fcolor-diagnostics -pipe
> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2
> -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated
> -Wformat-nonliteral -Wformat-security -Wmissing-declarations
> -Wmissing-prototypes -Wnested-externs -Wold-style-definition
> -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -
> Wwrite-strings -Wno-address-of-packed-member
> -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native
> -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -MD -MQ
> drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_dlb2.c.o -MF
> drivers/libtmp_rt
> e_event_dlb2.a.p/event_dlb2_dlb2.c.o.d -o
> drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_dlb2.c.o -c
> ../drivers/event/dlb2/dlb2.c
> ../drivers/event/dlb2/dlb2.c:2231:1: error: unused function
> 'dlb2_consume_qe_immediate' [-Werror,-Wunused-function]
> dlb2_consume_qe_immediate(struct dlb2_port *qm_port, int num)
> ^
> ../drivers/event/dlb2/dlb2.c:2271:1: error: unused function
> 'dlb2_construct_token_pop_qe' [-Werror,-Wunused-function]
> dlb2_construct_token_pop_qe(struct dlb2_port *qm_port, int idx)
> ^
> 2 errors generated.
> [2264/2494] Generating rte_event_octeontx.sym_chk with a meson_exe.py
> custom command
> [2265/2494] Generating rte_baseband_fpga_lte_fec.sym_chk with a
> meson_exe.py custom command
> [2266/2494] Generating rte_event_octeontx2.sym_chk with a meson_exe.py
> custom command
> [2267/2494] Generating rte_event_sw.sym_chk with a meson_exe.py custom
> command
> [2268/2494] Linking target lib/librte_stack.so.21.0
> [2269/2494] Linking target lib/librte_jobstats.so.21.0
> [2270/2494] Linking target lib/librte_cfgfile.so.21.0
> 

Fixed in local repo. Will be present in next patch-set.

Sorry that I can't seem to clean these all up in a single commit, and instead have been
fixing them incrementally. I have built every patch of every patch-set, and no
errors are reported with gcc. Unfortunately, we do not have clang installed on our servers, and I have not yet
been able to find a way to get gcc to flag these errors.  I have tried setting
cflags += '-Wunsued' in my meson.build file, but that did not help.




More information about the dev mailing list