[dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop public interface

McDaniel, Timothy timothy.mcdaniel at intel.com
Sat Oct 31 20:19:25 CET 2020



> -----Original Message-----
> From: McDaniel, Timothy
> Sent: Saturday, October 31, 2020 11:38 AM
> To: David Marchand <david.marchand at redhat.com>
> Cc: Ray Kinsella <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>;
> dev <dev at dpdk.org>; Carrillo, Erik G <Erik.G.Carrillo at intel.com>; Eads, Gage
> <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>;
> Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Thomas Monjalon
> <thomas at monjalon.net>
> Subject: RE: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop
> public interface
> 
> 
> 
> > -----Original Message-----
> > From: David Marchand <david.marchand at redhat.com>
> > Sent: Saturday, October 31, 2020 5:52 AM
> > To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> > Cc: Ray Kinsella <mdr at ashroe.eu>; Neil Horman <nhorman at tuxdriver.com>;
> > dev <dev at dpdk.org>; Carrillo, Erik G <Erik.G.Carrillo at intel.com>; Eads, Gage
> > <gage.eads at intel.com>; Van Haaren, Harry <harry.van.haaren at intel.com>;
> > Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Thomas Monjalon
> > <thomas at monjalon.net>
> > Subject: Re: [dpdk-dev] [PATCH v8 20/23] event/dlb2: add PMD's token pop
> > public interface
> >
> > On Sat, Oct 31, 2020 at 3:07 AM Timothy McDaniel
> > <timothy.mcdaniel at intel.com> wrote:
> > > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> > > index a9c12d1..00f13e2 100644
> > > --- a/doc/api/doxy-api-index.md
> > > +++ b/doc/api/doxy-api-index.md
> > > @@ -52,6 +52,7 @@ The public API headers are grouped by topics:
> > >    [dpaa2_cmdif]        (@ref rte_pmd_dpaa2_cmdif.h),
> > >    [dpaa2_qdma]         (@ref rte_pmd_dpaa2_qdma.h),
> > >    [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
> > > +  [dlb2]              (@ref rte_pmd_dlb2.h)
> >
> > This comment applies to the dlb series too:
> >
> > Those lines should be aligned with spaces, not tabs.
> > And the crypto_scheduler line is missing a comma.
> >
> >
> > >
> > >  - **memory**:
> > >    [memseg]             (@ref rte_memory.h),
> >
> >
> > --
> > David Marchand
> 
> Fixed in local repos for both DLB and DLB2. Will be included in next rev of patch-
> sets.
> 
> Tim

I have made the requested changes to doc/api/doxy-api-index.md in DLB and DLB2 repos, but I still see this error:
/home/travis/build/ovsrobot/dpdk/doc/api/doxy-api-index.md:54: error: unable to resolve reference to `rte_pmd_dlb.h' for \ref command (warning treated as error, aborting

I was hoping that the formatting issues were the culprit, but apparently not.  Any thoughts?

Thanks,
Tim


More information about the dev mailing list