[dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Tue, 2020-09-01 at 14:32 +0200, Christian Ehrhardt wrote:
> On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca at debian.org> wrote:
> > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > Hi all,
> > > 
> > > Here is a list of patches targeted for stable release 19.11.4.
> > > 
> > > The planned date for the final release is August 31st.
> > > 
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final release
> > > the fixes and reported validations will be added to the release notes.
> > > 
> > > A release candidate tarball can be found at:
> > > 
> > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > 
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > >     https://dpdk.org/browse/dpdk-stable/
> > > 
> > > Thanks.
> > > 
> > > Luca Boccassi
> > 
> > Microsoft's regression tests are still running, delaying until Thursday
> > the 3rd. Apologies for any inconvenience.
> 
> Due to report on OVS failing to build I happened to find that 19.11.4
> has massively changed linking.
> => https://paste.ubuntu.com/p/znCRR4gpjP/
> 
> This was meant to be helpful for sure and I assume is around:
> 48f7fd27f6 build/pkg-config: prevent overlinking
> 2d1535d592 build/pkg-config: improve static linking flags
> 9fb13a12c1 build/pkg-config: output drivers first for static build
> 59b108d824 build/pkg-config: move pkg-config file creation
> aea915e944 devtools: test static linkage with pkg-config
> 
> But overlinking has effectively become underlinking now
> https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> 
> /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> in function `rte_eth_from_rings':
> (.text+0x91c): undefined reference to `rte_vdev_init'
> /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> in function `vdrvinitfn_pmd_ring_drv':
> (.text.startup+0x28): undefined reference to `rte_vdev_register'
> collect2: error: ld returned 1 exit status
> 
> Also as you can see in the pastebin above, CFlags and Libs massively
> shrunk and likely too much so.
> 
> Given that this should be a stable release I'd ask to back out those
> changes so that a test build creates the same .pc file as before -
> would that make sense?

Paging Bruce and Ian - IIRC OVS explicitly asked for that series to be
backported and took a dependency on it, so removing it might cause
breakages for them? Ian?

Bruce, have you see the error reported by Christian before?

-- 
Kind regards,
Luca Boccassi