[dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type

Ajit Khaparde ajit.khaparde at broadcom.com
Wed Sep 2 06:03:56 CEST 2020


On Wed, Aug 5, 2020 at 8:52 PM Gaurav Singh <gaurav1086 at gmail.com> wrote:

> vxlan_spec cannot be NULL since its already being accessed
> before. Remove the redundant NULL check.
>
> Signed-off-by: Gaurav Singh <gaurav1086 at gmail.com>
>
Patch applied to dpdk-next-net-brcm. Thanks


> ---
>  drivers/net/bnxt/bnxt_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index 320b53d94..c1c59bbe5 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
>                         }
>
>                         /* Check if VNI is masked. */
> -                       if (vxlan_spec && vxlan_mask) {
> +                       if (vxlan_mask != NULL) {
>                                 vni_masked =
>                                         !!memcmp(vxlan_mask->vni, vni_mask,
>                                                  RTE_DIM(vni_mask));
> --
> 2.17.1
>
>


More information about the dev mailing list