[dpdk-dev] [PATCH v1 0/4] Remove RTE_MACHINE_CPUFLAG_ macros

[Nicolau, Radu]

On 9/2/2020 5:57 PM, David Christensen wrote:
> On 9/2/20 3:43 AM, Radu Nicolau wrote:
>> Remove RTE_MACHINE_CPUFLAG_ macros from the build.
>> Deprecation notice sent, pasted here for reference:
>>
>>    build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be 
>> removed
>>    from the build. The information provided by these macros is available
>>    through standard compiler macros. For example, 
>> RTE_MACHINE_CPUFLAG_SSE3
>>    duplicates the compiler-provided macro __SSE3__.
>>
>> Radu Nicolau (4):
>>    x86: change cpuflag macros to compiler macros
>>    arm: change cpuflag macros to compiler macros
>>    ppc: change cpuflag macros to compiler macros
>>    doc: remove reference to RTE_MACHINE_CPUFLAG
>
> I'm not too familiar with clang and icc.  Do all compilers use the 
> same macro definitions for the same CPU features?  I would have 
> thought the RTE_* definitions were there because there are compiler or 
> compiler version differences that need to be supported.
>
> Dave

All supported compilers should have these defines, and the 
RTE_MACHINE_CPU macros were defined based on the compiler defined 
macros, as an unnecessary extra step.

Furthermore, as per Bruce's comment, new features will be easily 
implemented directly in the relevant sections without needing to update 
the build system.