[dpdk-dev] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs
Honnappa Nagarahalli
Honnappa.Nagarahalli at arm.com
Mon Sep 14 06:28:09 CEST 2020
<snip>
>
> When enqueue one element to ring in the performance test, a pointer should
> be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of
> void *pointers.
>
> Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")
> Cc: honnappa.nagarahalli at arm.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wang2 at arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> Reviewed-by: Phil Yang <phil.yang at arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> ---
> app/test/test_ring.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_ring.h b/app/test/test_ring.h index
> aa6ae67ca..d4b15af7c 100644
> --- a/app/test/test_ring.h
> +++ b/app/test/test_ring.h
> @@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, int
> esize, unsigned int n,
> if ((esize) == -1)
> switch (api_type) {
> case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE):
> - return rte_ring_enqueue(r, obj);
> + return rte_ring_enqueue(r, *obj);
> case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE):
> - return rte_ring_sp_enqueue(r, obj);
> + return rte_ring_sp_enqueue(r, *obj);
> case (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE):
> - return rte_ring_mp_enqueue(r, obj);
> + return rte_ring_mp_enqueue(r, *obj);
> case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK):
> return rte_ring_enqueue_bulk(r, obj, n, NULL);
> case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK):
> --
> 2.17.1
More information about the dev
mailing list