[dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

David Marchand david.marchand at redhat.com
Fri Sep 18 09:31:20 CEST 2020


On Fri, Sep 18, 2020 at 9:12 AM Somnath Kotur
<somnath.kotur at broadcom.com> wrote:
>
> On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot
> <thierry.herbelot at 6wind.com> wrote:
> >
> >   .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
> >   .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
> >     comparison is always true due to limited range of data type [-Werror=type-limits]
> >   for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
> >                             ^
> >
> > Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> > Cc: Ajit Khaparde <ajit.khaparde at broadcom.com>
> > Cc: Somnath Kotur <somnath.kotur at broadcom.com>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
> > ---
> >  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > index 9fb1a028ff66..ff5aed3d74c4 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > @@ -397,7 +397,7 @@ void
> >  bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> >  {
> >         struct bnxt_ulp_df_rule_info *info;
> > -       uint8_t port_id;
> > +       uint16_t port_id;
> >
> >         if (!BNXT_TRUFLOW_EN(bp) ||
> >             BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> > --
> > 2.27.0
> >
> Acked-by: Somnath Kotur <somnath.kotur at broadcom.com>
>

This patch rang a bell.
There is the exact same patch proposed by Xia with a comment, so I
guess Xia is still working on it?
https://patchwork.dpdk.org/patch/75177/#117201


-- 
David Marchand



More information about the dev mailing list