[dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets

Ori Kam orika at nvidia.com
Mon Sep 21 09:29:12 CEST 2020


Hi

> -----Original Message-----
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets
> 
> 31/08/2020 19:00, Stephen Hemminger:
> > On Mon, 31 Aug 2020 13:23:33 +0530
> > Nipun Gupta <nipun.gupta at nxp.com> wrote:
> >
> > > This change adds a RX offload capability where hardware can drop the
> > > packets in case there is an error in the packet such as L3 checksum
> > > error or L4 checksum.
> > >
> > > Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> > > Signed-off-by: Rohit Raj <rohit.raj at nxp.com>
> > > ---
> > > +#define DEV_RX_OFFLOAD_ERR_PKT_DROP	0x00100000
> 
> Please add RTE_ prefix, even if older macros don't have it.
> We could (in a separate effort) alias old ones with RTE_ prefixed names.
> 
> > Could/should this be an rte_flow action as well?
> 
> I feel rte_flow API is not appropriate here.
> Ori, any opinion?
> 
I also don't think this is relevant action in case of rte_flow,
If we want to support such a thing in rte_flow we should 
add item that matches on error and then use the drop action.

Best,
Ori


More information about the dev mailing list