[dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

[Thomas Monjalon]

23/09/2020 18:28, David Marchand:
> On Wed, Sep 23, 2020 at 6:08 PM Dumitrescu, Cristian
> <cristian.dumitrescu at intel.com> wrote:
> > > - On the patch titles, check-git-log.sh reports:
> > > Wrong headline case:
> > >             "pipeline: add SWX dma instruction": dma --> DMA
> > > Wrong headline case:
> > >             "pipeline: add SWX rx and extract instructions": rx --> Rx
> > > Wrong headline case:
> > >             "pipeline: add SWX tx and emit instructions": tx --> Tx
> > > Wrong headline case:
> > >             "pipeline: introduce SWX xor instruction": xor --> XOR
> > >
> >
> > I can do this change, but IMO it is not the right choice here, as in this particular case we have instructions that are called "rx", "tx", "dma", "and", "or", "xor", etc. So it is the name of an instruction rather than a text abbreviation. Hence, I think these messages are not really applicable here. What do you think?
> 
> For this reason I am ok with ignoring too, Thomas wdyt?

The general idea of titles is to not use exact same wording as in code
(no function or variable names for instance).
For the instructions, I don't know.
If you think it is better as lowercase, I can be convinced.