[dpdk-dev] [PATCH v3 02/29] ethdev: allow drivers to return error on close

[Wang, Haiyue]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, September 29, 2020 07:14
> To: dev at dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; arybchenko at solarflare.com; Xu, Rosen <rosen.xu at intel.com>;
> Sachin Saxena <sachin.saxena at oss.nxp.com>; Liron Himi <lironh at marvell.com>; John W. Linville
> <linville at tuxdriver.com>; Loftus, Ciara <ciara.loftus at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>;
> Shepard Siegel <shepard.siegel at atomicrules.com>; Ed Czeck <ed.czeck at atomicrules.com>; John Miller
> <john.miller at atomicrules.com>; Igor Russkikh <igor.russkikh at aquantia.com>; Pavel Belous
> <pavel.belous at aquantia.com>; Steven Webster <steven.webster at windriver.com>; Matt Peters
> <matt.peters at windriver.com>; Somalapuram Amaranath <asomalap at amd.com>; Rasesh Mody <rmody at marvell.com>;
> Shahed Shaikh <shshaikh at marvell.com>; Ajit Khaparde <ajit.khaparde at broadcom.com>; Somnath Kotur
> <somnath.kotur at broadcom.com>; Chas Williams <chas3 at att.com>; Wei Hu (Xavier) <xavier.huwei at huawei.com>;
> Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>; Hemant Agrawal <hemant.agrawal at nxp.com>; Guo, Jia
> <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>; Marcin Wojtas <mw at semihalf.com>; Michal
> Krawczyk <mk at semihalf.com>; Guy Tzalik <gtzalik at amazon.com>; Evgeny Schemeilin <evgenys at amazon.com>;
> Igor Chauskin <igorch at amazon.com>; Gagandeep Singh <g.singh at nxp.com>; John Daley <johndale at cisco.com>;
> Hyong Youb Kim <hyonkim at cisco.com>; Gaetan Rivet <grive at u256.net>; Wang, Xiao W
> <xiao.w.wang at intel.com>; Ziyang Xuan <xuanziyang2 at huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun at huawei.com>; Guoyang Zhou <zhouguoyang at huawei.com>; Min Hu (Connor)
> <humin29 at huawei.com>; Yisen Zhuang <yisen.zhuang at huawei.com>; Xing, Beilei <beilei.xing at intel.com>; Wu,
> Jingjing <jingjing.wu at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Alfredo Cardigliano
> <cardigliano at ntop.org>; Shijith Thotton <sthotton at marvell.com>; Srisivasubramanian Srinivasan
> <srinivasan at marvell.com>; Jakub Grajciar <jgrajcia at cisco.com>; Matan Azrad <matan at nvidia.com>; Shahaf
> Shuler <shahafs at nvidia.com>; Viacheslav Ovsiienko <viacheslavo at nvidia.com>; Zyta Szpak
> <zr at semihalf.com>; Stephen Hemminger <sthemmin at microsoft.com>; K. Y. Srinivasan <kys at microsoft.com>;
> Haiyang Zhang <haiyangz at microsoft.com>; Long Li <longli at microsoft.com>; Martin Spinler
> <spinler at cesnet.cz>; Heinrich Kuhn <heinrich.kuhn at netronome.com>; Harman Kalra <hkalra at marvell.com>;
> Jerin Jacob <jerinj at marvell.com>; Nithin Dabilpuram <ndabilpuram at marvell.com>; Kiran Kumar K
> <kirankumark at marvell.com>; Akhil Goyal <akhil.goyal at nxp.com>; Singh, Jasvinder
> <jasvinder.singh at intel.com>; Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Wiles, Keith
> <keith.wiles at intel.com>; Maciej Czekaj <mczekaj at marvell.com>; Maxime Coquelin
> <maxime.coquelin at redhat.com>; Xia, Chenbo <chenbo.xia at intel.com>; Wang, Zhihong
> <zhihong.wang at intel.com>; Yong Wang <yongwang at vmware.com>
> Subject: [PATCH v3 02/29] ethdev: allow drivers to return error on close
> 
> The device operation .dev_close was returning void.
> This driver interface is changed to return an int.
> 
> Note that the API rte_eth_dev_close() is still returning void,
> although a deprecation notice is pending to change it as well.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Reviewed-by: Rosen Xu <rosen.xu at intel.com>
> Reviewed-by: Sachin Saxena <sachin.saxena at oss.nxp.com>
> Reviewed-by: Liron Himi <lironh at marvell.com>
> ---

>  drivers/net/e1000/em_ethdev.c             |  6 ++++--
>  drivers/net/e1000/igb_ethdev.c            | 12 ++++++++----
>  drivers/net/igc/igc_ethdev.c              |  6 ++++--
>  drivers/net/ixgbe/ixgbe_ethdev.c          | 11 +++++++----

For e1000/igc/ixgbe

Reviewed-by: Haiyue Wang <haiyue.wang at intel.com>

> 2.28.0