[dpdk-dev] [PATCH v3 28/29] ethdev: reset all when releasing a port

Wang, Haiyue haiyue.wang at intel.com
Tue Sep 29 04:34:43 CEST 2020


> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, September 29, 2020 07:15
> To: dev at dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; arybchenko at solarflare.com; Shepard Siegel
> <shepard.siegel at atomicrules.com>; Ed Czeck <ed.czeck at atomicrules.com>; John Miller
> <john.miller at atomicrules.com>; Igor Russkikh <igor.russkikh at aquantia.com>; Pavel Belous
> <pavel.belous at aquantia.com>; Somalapuram Amaranath <asomalap at amd.com>; Ajit Khaparde
> <ajit.khaparde at broadcom.com>; Somnath Kotur <somnath.kotur at broadcom.com>; Chas Williams
> <chas3 at att.com>; Wei Hu (Xavier) <xavier.huwei at huawei.com>; Hemant Agrawal <hemant.agrawal at nxp.com>;
> Sachin Saxena <sachin.saxena at oss.nxp.com>; Guo, Jia <jia.guo at intel.com>; Wang, Haiyue
> <haiyue.wang at intel.com>; Marcin Wojtas <mw at semihalf.com>; Michal Krawczyk <mk at semihalf.com>; Guy
> Tzalik <gtzalik at amazon.com>; Evgeny Schemeilin <evgenys at amazon.com>; Igor Chauskin <igorch at amazon.com>;
> Zhang, Qi Z <qi.z.zhang at intel.com>; Wang, Xiao W <xiao.w.wang at intel.com>; Ziyang Xuan
> <xuanziyang2 at huawei.com>; Xiaoyun Wang <cloud.wangxiaoyun at huawei.com>; Guoyang Zhou
> <zhouguoyang at huawei.com>; Min Hu (Connor) <humin29 at huawei.com>; Yisen Zhuang <yisen.zhuang at huawei.com>;
> Xing, Beilei <beilei.xing at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Yang, Qiming
> <qiming.yang at intel.com>; Alfredo Cardigliano <cardigliano at ntop.org>; Shijith Thotton
> <sthotton at marvell.com>; Srisivasubramanian Srinivasan <srinivasan at marvell.com>; Stephen Hemminger
> <sthemmin at microsoft.com>; K. Y. Srinivasan <kys at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>;
> Long Li <longli at microsoft.com>; Harman Kalra <hkalra at marvell.com>; Rasesh Mody <rmody at marvell.com>;
> Shahed Shaikh <shshaikh at marvell.com>; Wiles, Keith <keith.wiles at intel.com>; Maxime Coquelin
> <maxime.coquelin at redhat.com>; Xia, Chenbo <chenbo.xia at intel.com>; Wang, Zhihong
> <zhihong.wang at intel.com>; Yong Wang <yongwang at vmware.com>
> Subject: [PATCH v3 28/29] ethdev: reset all when releasing a port
> 
> The function rte_eth_dev_release_port() was resetting partially
> the struct rte_eth_dev. The drivers were completing it
> with more pointers set to NULL in the close or remove operations.
> 
> A full memset is done so most of those assignments become useless.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> ---


>  drivers/net/e1000/em_ethdev.c          | 4 ----
>  drivers/net/e1000/igb_ethdev.c         | 8 --------
>  drivers/net/ixgbe/ixgbe_ethdev.c       | 8 --------

For e1000/ixgbe

Reviewed-by: Haiyue Wang <haiyue.wang at intel.com>

> --
> 2.28.0



More information about the dev mailing list