[dpdk-dev] [PATCH v3 23/29] drivers/net: check process type in close operation

[Wang, Haiyue]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, September 29, 2020 07:15
> To: dev at dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; arybchenko at solarflare.com; Xu, Rosen <rosen.xu at intel.com>;
> Sachin Saxena <sachin.saxena at oss.nxp.com>; Ajit Khaparde <ajit.khaparde at broadcom.com>; Liron Himi
> <lironh at marvell.com>; Loftus, Ciara <ciara.loftus at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>;
> Shepard Siegel <shepard.siegel at atomicrules.com>; Ed Czeck <ed.czeck at atomicrules.com>; John Miller
> <john.miller at atomicrules.com>; Steven Webster <steven.webster at windriver.com>; Matt Peters
> <matt.peters at windriver.com>; Somnath Kotur <somnath.kotur at broadcom.com>; Rahul Lakkireddy
> <rahul.lakkireddy at chelsio.com>; Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>;
> Marcin Wojtas <mw at semihalf.com>; Michal Krawczyk <mk at semihalf.com>; Guy Tzalik <gtzalik at amazon.com>;
> Evgeny Schemeilin <evgenys at amazon.com>; Igor Chauskin <igorch at amazon.com>; Gagandeep Singh
> <g.singh at nxp.com>; John Daley <johndale at cisco.com>; Hyong Youb Kim <hyonkim at cisco.com>; Wang, Xiao W
> <xiao.w.wang at intel.com>; Ziyang Xuan <xuanziyang2 at huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun at huawei.com>; Guoyang Zhou <zhouguoyang at huawei.com>; Xing, Beilei
> <beilei.xing at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Yang, Qiming <qiming.yang at intel.com>;
> Alfredo Cardigliano <cardigliano at ntop.org>; Shijith Thotton <sthotton at marvell.com>; Srisivasubramanian
> Srinivasan <srinivasan at marvell.com>; Matan Azrad <matan at nvidia.com>; Shahaf Shuler
> <shahafs at nvidia.com>; Zyta Szpak <zr at semihalf.com>; Stephen Hemminger <sthemmin at microsoft.com>; K. Y.
> Srinivasan <kys at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>; Long Li <longli at microsoft.com>;
> Martin Spinler <spinler at cesnet.cz>; Heinrich Kuhn <heinrich.kuhn at netronome.com>; Harman Kalra
> <hkalra at marvell.com>; Akhil Goyal <akhil.goyal at nxp.com>; Jerin Jacob <jerinj at marvell.com>; Maciej
> Czekaj <mczekaj at marvell.com>; Maxime Coquelin <maxime.coquelin at redhat.com>; Xia, Chenbo
> <chenbo.xia at intel.com>; Wang, Zhihong <zhihong.wang at intel.com>; Yong Wang <yongwang at vmware.com>;
> Burakov, Anatoly <anatoly.burakov at intel.com>
> Subject: [PATCH v3 23/29] drivers/net: check process type in close operation
> 
> The secondary processes are not allowed to release shared resources.
> Only process-private resources should be freed in a secondary process.
> Most of the time, there is no process-private resource,
> so the close operation is just forbidden in a secondary process.
> 
> After adding proper check in the port close functions,
> some redundant checks in the device remove functions are dropped.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Reviewed-by: Rosen Xu <rosen.xu at intel.com>
> Reviewed-by: Sachin Saxena <sachin.saxena at oss.nxp.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> Reviewed-by: Liron Himi <lironh at marvell.com>
> ---


>  drivers/net/e1000/em_ethdev.c           |  3 +++
>  drivers/net/e1000/igb_ethdev.c          |  6 +++++
>  drivers/net/igc/igc_ethdev.c            |  6 ++---
>  drivers/net/ixgbe/ixgbe_ethdev.c        |  4 ++++

For e1000/igc/ixgbe

Reviewed-by: Haiyue Wang <haiyue.wang at intel.com>

> --
> 2.28.0