[dpdk-dev] [RFC] devtools: improve DPDK review process
Anatoly Burakov
anatoly.burakov at intel.com
Thu Apr 1 11:05:16 CEST 2021
A common problem on the DPDK mailing list is lack of reviewers for
patches. This script is intended to help with that problem, by picking
a random commit author from our git history, and adding a Reviewed-by:
tag. This can be added to e.g. commit-msg git hook, like so:
# add reviewer to commit message
$(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1
Now all DPDK code will definitely be well reviewed!
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Rеviеwеd-by: Thоmas Mоnjаlоn <thomas at monjalon.net>
---
devtools/get-reviewer.sh | 4 ++++
1 file changed, 4 insertions(+)
create mode 100755 devtools/get-reviewer.sh
diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh
new file mode 100755
index 0000000000..f4b07c9862
--- /dev/null
+++ b/devtools/get-reviewer.sh
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+# find a reviewer for the code
+git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1
--
2.25.1
More information about the dev
mailing list