[dpdk-dev] [PATCH v3 3/5] kvargs: add get by key function

[Xueming(Steven) Li]

>-----Original Message-----
>From: Kinsella, Ray <mdr at ashroe.eu>
>Sent: Thursday, April 1, 2021 5:06 PM
>To: Xueming(Steven) Li <xuemingl at nvidia.com>; NBU-Contact-Thomas Monjalon <thomas at monjalon.net>; Gaetan Rivet
><gaetanr at nvidia.com>
>Cc: dev at dpdk.org; Asaf Penso <asafp at nvidia.com>; Olivier Matz <olivier.matz at 6wind.com>; Neil Horman
><nhorman at tuxdriver.com>
>Subject: Re: [PATCH v3 3/5] kvargs: add get by key function
>
>
>
>On 30/03/2021 13:15, Xueming Li wrote:
>> Adds a new function to get value of a specific key from kvargs list.
>>
>> Signed-off-by: Xueming Li <xuemingl at nvidia.com>
>> ---
>>  lib/librte_kvargs/rte_kvargs.c | 20 ++++++++++++++++++++
>> lib/librte_kvargs/rte_kvargs.h | 21 +++++++++++++++++++++
>> lib/librte_kvargs/version.map  |  1 +
>>  3 files changed, 42 insertions(+)
>>
>
>[SNIP]
>
>> diff --git a/lib/librte_kvargs/version.map
>> b/lib/librte_kvargs/version.map index ed375bf4a3..e2bf792c60 100644
>> --- a/lib/librte_kvargs/version.map
>> +++ b/lib/librte_kvargs/version.map
>> @@ -12,6 +12,7 @@ DPDK_21 {
>>  EXPERIMENTAL {
>>  	global:
>>
>Please separate rte_kvargs_get from the other symbols.
>And add #21.05 in front, so we know when the symbol got added.

Good point, thanks
>
>> +	rte_kvargs_get;
>>  	rte_kvargs_parse_delim;
>>  	rte_kvargs_strcmp;
>>
>>