[dpdk-dev] [RFC PATCH 00/14] Build file update proposals

Bruce Richardson bruce.richardson at intel.com
Thu Apr 1 16:10:04 CEST 2021


On Thu, Apr 01, 2021 at 03:36:39PM +0200, Thomas Monjalon wrote:
> 01/04/2021 13:49, Bruce Richardson:
> > This RFC contains 5 changes/updates to the DPDK build and build files. These
> > updates all assume that the minimum version for DPDK has increased to at least
> > meson 0.49 as proposed in [1].
> > 
> > The changes in this set are:
> > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels
> >    in the foreach loops when building library or driver components.
> > 2. For libraries, drop support for header-only libraries, which was added just
> >    for the "compat" lib which had a single header, and is now part of EAL. This
> >    similarly reduces indentation levels and makes the code easier to follow
> > 3. Since the larger blocks of meson code in our repo is seeing massive
> >    whitespace changes, take the opportunity to switch our indentation style for
> >    meson files from that of C-files using tabs, to Meson/Python style using
> >    spaces. [More below on this for discussion]
> > 4. Remove the "librte_" prefix from all our library directories. While as useful
> >    cleanup, the main driver for this was that it simplifies the matching for #5
> >    below.
> > 5. Add a "disable_libs" build option to allow the user to optionally not build
> >    certain components. Include in this an explicit list of libraries which are
> >    "known safe" to disable in the build. For now this is a short list of three
> >    libs, all of which are safe because they are not buildable on FreeBSD. More
> >    work is needed to expand this list in future.
> > 
> > Of these changes, I expect #3 to be most controversial.
> 
> Did you choose April 1st on purpose?
> 
It kinda just happened that way. This patchset has been in the works for
some time, but never got to an RFC point before now. And what with more
serious things, I never got the opportunity to prepare a *proper* April 1st
patchset. :-)


More information about the dev mailing list