[dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation

Thomas Monjalon thomas at monjalon.net
Mon Apr 5 21:01:14 CEST 2021


There is no previous commit with net/mlx5/windows as title prefix.
In general, there is "on Windows" at the end of the title.
This way we can have the same formatting when fixing the common code
for a Windows case.

05/04/2021 18:18, Tal Shnaiderman:
> In Windows DevX returns the value of the current link speed
> in bps rate, the conversion to the Mbps rate expected by DPDK
> is incorrect and fixed.

"was" incorrect.

I think you should explain the confusion between Mbit/s and Mibit/s.

> -	dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1024 * 1024);
> +	dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1000 * 1000);





More information about the dev mailing list