[dpdk-dev] [PATCH 1/2] net/softnic: check meter packet mode

Li Zhang lizh at nvidia.com
Thu Apr 8 04:31:42 CEST 2021


Hi Cristian,

> -----Original Message-----
> From: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> Sent: Thursday, April 8, 2021 4:13 AM
> To: Li Zhang <lizh at nvidia.com>; dekelp at nvidia.com; Ori Kam
> <orika at nvidia.com>; Slava Ovsiienko <viacheslavo at nvidia.com>; Matan
> Azrad <matan at nvidia.com>; Shahaf Shuler <shahafs at nvidia.com>;
> lironh at marvell.com; Singh, Jasvinder <jasvinder.singh at intel.com>
> Cc: dev at dpdk.org; NBU-Contact-Thomas Monjalon <thomas at monjalon.net>;
> Raslan Darawsheh <rasland at nvidia.com>; Roni Bar Yanai
> <roniba at nvidia.com>
> Subject: RE: [PATCH 1/2] net/softnic: check meter packet mode
> 
> External email: Use caution opening links or attachments
> 
> 
> > -----Original Message-----
> > From: Li Zhang <lizh at nvidia.com>
> > Sent: Thursday, April 1, 2021 7:16 AM
> > To: dekelp at nvidia.com; orika at nvidia.com; viacheslavo at nvidia.com;
> > matan at nvidia.com; shahafs at nvidia.com; Dumitrescu, Cristian
> > <cristian.dumitrescu at intel.com>; lironh at marvell.com; Singh, Jasvinder
> > <jasvinder.singh at intel.com>
> > Cc: dev at dpdk.org; thomas at monjalon.net; rasland at nvidia.com;
> > roniba at nvidia.com
> > Subject: [PATCH 1/2] net/softnic: check meter packet mode
> >
> > Currently meter algorithms only supports bytes per second(BPS).
> > Check packet_mode set to TRUE are rejected.
> >
> > Signed-off-by: Li Zhang <lizh at nvidia.com>
> > ---
> >  drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c
> > b/drivers/net/softnic/rte_eth_softnic_meter.c
> > index 0cbf94e8b0..50db74f52f 100644
> > --- a/drivers/net/softnic/rte_eth_softnic_meter.c
> > +++ b/drivers/net/softnic/rte_eth_softnic_meter.c
> > @@ -128,6 +128,14 @@ meter_profile_check(struct rte_eth_dev *dev,
> >                       NULL,
> >                       "Metering alg not supported");
> >
> > +     /* Not support packet mode, just support byte mode. */
> > +     if (profile->packet_mode)
> > +             return -rte_mtr_error_set(error,
> > +                     EINVAL,
> > +                     RTE_MTR_ERROR_TYPE_METER_PROFILE,
> 
> Can you please add a new error type for this specific error case, i.e.
> RTE_MTR_ERROR_TYPE_METER_PROFILE_PACKET_MODE.
> 
Thanks, I will add it in V2 patch.

> > +                     NULL,
> > +                     "Meter packet mode not supported");
> > +
> >       return 0;
> >  }
> >
> > --
> > 2.27.0



More information about the dev mailing list