[dpdk-dev] [PATCH] app: fix redundant comparison

Stephen Hemminger stephen at networkplumber.org
Mon Apr 19 17:06:43 CEST 2021


On Mon, 19 Apr 2021 20:29:51 +0800
"Min Hu (Connor)" <humin29 at huawei.com> wrote:

> The return value of 'rte_eal_cleanup' is always zero, so comparison
> with zero is redundant.
> 
> This patch fixed it by deleting the redundant comparison.
> 
> Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit")
> Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
> Fixes: 5e516c89830a ("app/testpmd: call cleanup on exit")
> Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown")
> Fixes: 48be180de631 ("eal: move OS common debug functions to single file")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>

Please keep it in testpmd, which should be checking everything.
For the others, the message doesn't add any value to the user and can be removed.




More information about the dev mailing list