[dpdk-dev] [PATCH v2 00/16] Build file updates

Thomas Monjalon thomas at monjalon.net
Wed Apr 21 14:08:58 CEST 2021


20/04/2021 12:22, Bruce Richardson:
> This set contains 5 changes/updates to the DPDK build and build files.
> 
> The changes in this set are:
> 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels
>    in the foreach loops when building library or driver components.
> 2. For libraries, drop support for header-only libraries, which was added just
>    for the "compat" lib which had a single header, and is now part of EAL. This
>    similarly reduces indentation levels and makes the code easier to follow
> 3. Since the larger blocks of meson code in our repo is seeing massive
>    whitespace changes, take the opportunity to switch our indentation style for
>    meson files from that of C-files using tabs, to Meson/Python style using
>    spaces.[1]
> 4. Remove the "librte_" prefix from all our library directories. While as useful
>    cleanup, the main driver for this was that it simplifies the matching for #5
>    below.
> 5. Add a "disable_libs" build option to allow the user to optionally not build
>    certain components. Include in this an explicit list of libraries which are
>    "known safe" to disable in the build. For now this is a short list of three
>    libs, all of which are safe because they are not buildable on FreeBSD. More
>    work is needed to expand this list in future.
> 
> [1] https://mesonbuild.com/Style-guide.html#tabs-or-spaces

I went an extra mile to align files list in drivers.
That's a big bang applied for 21.05-rc1.

Please could you try to set up the git trick
to skip some of these changes in the git blame?

Thanks




More information about the dev mailing list