[dpdk-dev] [EXT] [PATCH 2/2] graph: fix dereferencing null pointer

Kiran Kumar Kokkilagadda kirankumark at marvell.com
Fri Apr 23 05:52:41 CEST 2021



> -----Original Message-----
> From: Min Hu (Connor) <humin29 at huawei.com>
> Sent: Thursday, April 22, 2021 5:22 PM
> To: dev at dpdk.org
> Cc: ferruh.yigit at intel.com; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
> Kiran Kumar Kokkilagadda <kirankumark at marvell.com>
> Subject: [EXT] [PATCH 2/2] graph: fix dereferencing null pointer
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: HongBo Zheng <zhenghongbo3 at huawei.com>
> 
> In function 'stats_mem_init', pointer 'stats' should be confirmed not null before
> memset it.
> 
> Fixes: af1ae8b6a32c ("graph: implement stats")
> Cc: stable at dpdk.org
> 
> Signed-off-by: HongBo Zheng <zhenghongbo3 at huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
> ---
>  lib/librte_graph/graph_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_graph/graph_stats.c b/lib/librte_graph/graph_stats.c index
> f698bb3..bdc8652 100644
> --- a/lib/librte_graph/graph_stats.c
> +++ b/lib/librte_graph/graph_stats.c
> @@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster,
>  	cluster_node_size = RTE_ALIGN(cluster_node_size,
> RTE_CACHE_LINE_SIZE);
> 
>  	stats = realloc(NULL, sz);
> -	memset(stats, 0, sz);
>  	if (stats) {
> +		memset(stats, 0, sz);
>  		stats->fn = fn;
>  		stats->cluster_node_size = cluster_node_size;
>  		stats->max_nodes = 0;
> --
> 2.7.4

Reviewed-by: Kiran Kumar K <kirankumark at marvell.com>



More information about the dev mailing list