[dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

[Wang, Haiyue]

> -----Original Message-----
> From: Hunt, David <david.hunt at intel.com>
> Sent: Monday, April 26, 2021 22:20
> To: Burakov, Anatoly <anatoly.burakov at intel.com>; dev at dpdk.org; Guo, Jia <jia.guo at intel.com>; Wang,
> Haiyue <haiyue.wang at intel.com>; Ananyev, Konstantin <konstantin.ananyev at intel.com>; Liang Ma
> <liang.j.ma at intel.com>
> Subject: Re: [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver
> 
> Hi Anatoly,
> 
> On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> > When .get_monitor_addr API was introduced, it was implemented in the
> > ixgbe driver, but only for the physical function; the virtual function
> > portion of the driver does not support that API.
> >
> > Add the missing function pointer to VF device structure.
> >
> > Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > ---
> >   drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ff65145f55..6cca039a11 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -605,6 +605,7 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
> >   	.rss_hash_update      = ixgbe_dev_rss_hash_update,
> >   	.rss_hash_conf_get    = ixgbe_dev_rss_hash_conf_get,
> >   	.tx_done_cleanup      = ixgbe_dev_tx_done_cleanup,
> > +	.get_monitor_addr     = ixgbe_get_monitor_addr,
> >   };
> >
> >   /* store statistics names and its offset in stats structure */
> 
> 
> Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual
> functions here, and can confirm that this patch resolves the issue.
> 
> Reviewed-by: David Hunt <david.hunt at intel.com>
> 
> 

Nice confirmation, thanks, David.

Acked-by: Haiyue Wang <haiyue.wang at intel.com>