[dpdk-dev] [PATCH v1] raw/ifpga: fix ifpga device name format

Ferruh Yigit ferruh.yigit at intel.com
Wed Apr 28 11:26:15 CEST 2021


On 4/22/2021 9:27 AM, Wei Huang wrote:
> The device name format used in ifpga_rawdev_create() was changed to
> "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy()
> was left as "IFPGA:%x:%02x.%x", it should be changed synchronously.
> 

Hi Wei,

If the name is significant, why not convert the format into a macro and use it?
This prevents further similar errors, also highlights that format should be
exact same.

> Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Wei Huang <wei.huang at intel.com>
> ---
>  drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
> index d9a46ef915..f591a87b49 100644
> --- a/drivers/raw/ifpga/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga/ifpga_rawdev.c
> @@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev)
>  	}
>  
>  	memset(name, 0, sizeof(name));
> -	snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%02x.%x",
> +	snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%02x:%02x.%x",
>  		pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function);
>  
>  	IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d",
> 



More information about the dev mailing list