[dpdk-dev] [EXTERNAL] Re: [PATCH v6 06/10] eal: add thread lifetime management

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Fri Apr 30 19:51:09 CEST 2021


2021-04-30 20:22 (UTC+0300), Dmitry Kozlyuk:
> 2021-04-29 21:31 (UTC+0000), Dmitry Malloy:
> > [...]
> > How about we defer fixing this to another follow-up change?  
> 
> I'm strictly against accepting code with known severe bugs.
> 
> Alternative:
> 
> 1. Don't add rte_thread_cancel() in public API.
> 2. Implement rte_thread_cancel() as internal API with cancellation tokens.
> 3. Rewrite DPDK code to use rte_thread_cancel().
> [...]

Or just don't export this function on Windows for now.
None of the drivers using it is soon to be enabled for Windows,
and portable apps don't need it anyway.



More information about the dev mailing list