[dpdk-dev] [PATCH v5] bus: clarify log for non-NUMA-aware devices
Thomas Monjalon
thomas at monjalon.net
Wed Aug 4 11:34:21 CEST 2021
04/08/2021 10:03, Dmitry Kozlyuk:
> PCI, vmbus, and auxiliary drivers printed a warning
> when NUMA node had been reported as (-1) or not reported by OS:
>
> EAL: Invalid NUMA socket, default to 0
>
> This message and its level might confuse users because the configuration
> is valid and nothing happens that requires attention or intervention.
> It was also printed without the device identification and with an indent
> (PCI only), which is confusing unless DEBUG logging is on to print
> the header message with the device name.
>
> Reduce level to INFO, reword the message, and suppress it when there is
> only one NUMA node because NUMA awareness does not matter in this case.
> Also, remove the indent for PCI.
>
> Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe")
> Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")
> Cc: stable at dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk at nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> Reviewed-by: Xueming Li <xuemingl at nvidia.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> ---
> The messages say "socket" and not "node", because this is current
> terminology in DPDK.
Yes we need to fix this terminology in a separate patch.
Applied, thanks.
More information about the dev
mailing list