[dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory

Thomas Monjalon thomas at monjalon.net
Fri Aug 6 17:43:08 CEST 2021


01/06/2021 03:56, Feifei Wang:
> From: Phil Yang <phil.yang at arm.com>
> 
> To make the code easier to maintain, use the absolute path for the
> default build_dir to avoid repeatedly calling of readlink.
[...]
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> -builds_dir=${DPDK_BUILD_TEST_DIR:-.}
> +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.})

It means that all uses of builds_dir will get the absolute path.
It may have consequences on meson configuration,
and will make outputs and logs longer.

I'm not sure this change is desirable.




More information about the dev mailing list