[dpdk-dev] [PATCH 04/28] net/ice/base: change dummy packets with VLAN

Guo, Junfeng junfeng.guo at intel.com
Tue Aug 10 06:35:16 CEST 2021



> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang at intel.com>
> Sent: Tuesday, August 10, 2021 10:51
> To: Yang, Qiming <qiming.yang at intel.com>
> Cc: Guo, Junfeng <junfeng.guo at intel.com>; dev at dpdk.org; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Swiatkowski, Michal
> <michal.swiatkowski at intel.com>
> Subject: [PATCH 04/28] net/ice/base: change dummy packets with VLAN
> 
> Ethertype was traded as VLAN tpid in dummy packets with VLAN.
> This led to a problem when user wanted to add filter for VLAN and
> ethertype.
> 
> Change ice_vlan_hdr to reflect correct order of VLAN fields in
> packets (VLAN tpid, VLAN id). Correct all dummy packets with VLAN.
> Move VLAN fields before ethertype and change offsets. Leave values
> from dummy packets unchanged as they fit to new VLAN layout.
> 
> Order of offsets in ice_prot_ext_tbl_entry for VLAN protocol should
> reflect order of fields in ice_vlan_hdr. However, hardware doesn't
> support matching on all tpid. This should be done by matching on
> packet flags. There is no FV word with protocol for VLAN and offset
> 2. Because of that, adding vlan tpid with not zero mask will lead
> to error in creating recipe.
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski at intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> ---
>  drivers/net/ice/base/ice_protocol_type.h |   2 +-
>  drivers/net/ice/base/ice_switch.c        | 148 +++++++++++------------
>  2 files changed, 73 insertions(+), 77 deletions(-)
> 
> --
> 2.26.2

Acked-by: Junfeng Guo <junfeng.guo at intel.com>

Regards,
Junfeng Guo


More information about the dev mailing list