[dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD

Heinrich Kuhn heinrich.kuhn at netronome.com
Fri Aug 13 14:46:52 CEST 2021



On 2021/07/29 15:47, Heinrich Kuhn wrote:
> This patch set restructures the NFP PMD, aligning it more with the
> common layout adopted by most other PMD's. Although the changes look
> fairly large, functionally nothing is added or removed from the driver
> and the existing code is mostly just reorganized into the familiar
> structure seen in other PMD's. Apart form adopting the common PMD layout
> this change should also aid in future feature development to the NFP
> PMD. The previous layout where most of the logic resided in a single
> file (nfp_net.c) would have become tedious to support going forward.
> 
> v3:
> * Avoid squashing the new firmware loader helper added in: 
>   https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781
> * Add dependency to patch-93299
> 
> v2:
> * Added missing sign-off's
> 
> ---

I think this refactor is a step in the right direction for the NFP PMD.
I do have a question/concern regarding future bug fixes. If this is
merged, back-porting any bug fixes will require a little bit more effort
since the code base will differ quite substantially for some time.

If there is a strong preference to avoid a situation like this we can
certainly live without this refactor

Regards,
Heinrich


More information about the dev mailing list