[dpdk-dev] [PATCH v2 8/8] examples: remove unnecessary include of atomic

[Joyce Kong]

<snip>

> Hi Joyce,
> 
> > -----Original Message-----
> > From: Joyce Kong <joyce.kong at arm.com>
> > Sent: Monday, August 23, 2021 1:50 PM
> > To: Chas Williams <chas3 at att.com>; Min Hu (Connor)
> > <humin29 at huawei.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>; Nicolau, Radu
> > <radu.nicolau at intel.com>; Akhil Goyal <gakhil at marvell.com>; Doherty,
> > Declan <declan.doherty at intel.com>; Sunil Kumar Kori
> > <skori at marvell.com>; Pavan Nikhilesh <pbhagavatula at marvell.com>;
> > Richardson, Bruce <bruce.richardson at intel.com>; Hunt, David
> > <david.hunt at intel.com>; Burakov, Anatoly <anatoly.burakov at intel.com>;
> > Marohn, Byron <byron.marohn at intel.com>; Wang, Yipeng1
> > <yipeng1.wang at intel.com>; Maxime Coquelin
> > <maxime.coquelin at redhat.com>; Xia, Chenbo <chenbo.xia at intel.com>
> > Cc: dev at dpdk.org; thomas at monjalon.net; david.marchand at redhat.com;
> > honnappa.nagarahalli at arm.com; ruifeng.wang at arm.com; nd at arm.com
> > Subject: [PATCH v2 8/8] examples: remove unnecessary include of atomic
> >
> > Remove the unnecessary header file rte_atomic.h included in example
> > module.
> >
> > Signed-off-by: Joyce Kong <joyce.kong at arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> > ---
> >  examples/bond/main.c                                       | 1 -
> >  examples/ip_fragmentation/main.c                           | 1 -
> >  examples/ip_reassembly/main.c                              | 1 -
> >  examples/ipsec-secgw/ipsec-secgw.c                         | 1 -
> >  examples/ipv4_multicast/main.c                             | 1 -
> >  examples/l2fwd-crypto/main.c                               | 1 -
> >  examples/l2fwd-event/l2fwd_common.h                        | 1 -
> >  examples/l2fwd-event/l2fwd_event.c                         | 1 -
> >  examples/l2fwd-keepalive/main.c                            | 1 -
> >  examples/l2fwd/main.c                                      | 1 -
> >  examples/l3fwd-acl/main.c                                  | 1 -
> >  examples/l3fwd-power/main.c                                | 1 -
> >  examples/l3fwd/main.c                                      | 1 -
> >  examples/link_status_interrupt/main.c                      | 1 -
> >  examples/multi_process/client_server_mp/mp_client/client.c | 1 -
> >  examples/multi_process/client_server_mp/mp_server/init.c   | 1 -
> >  examples/multi_process/simple_mp/main.c                    | 1 -
> >  examples/multi_process/simple_mp/mp_commands.c             | 1 -
> >  examples/multi_process/symmetric_mp/main.c                 | 1 -
> >  examples/server_node_efd/node/node.c                       | 1 -
> >  examples/server_node_efd/server/init.c                     | 1 -
> >  examples/vhost_blk/blk.c                                   | 1 -
> >  examples/vhost_blk/vhost_blk.c                             | 1 -
> 
> In vhost_blk.c, some atomic API is used (rte_atomic_thread_fence).
> Although it compiles well, I think it's better to keep the include rather than
> depending on other header includes rte_atomic.h.
> 
> Thanks,
> Chenbo
> 

Hi Chenbo, thanks for your suggestion, I'll rework with this patch in next version.

Joyce

> >  examples/vm_power_manager/channel_manager.c                | 1 -
> >  examples/vm_power_manager/channel_manager.h                | 1 -
> >  examples/vmdq/main.c                                       | 1 -
> >  examples/vmdq_dcb/main.c                                   | 1 -
> >  27 files changed, 27 deletions(-)