[dpdk-dev] [EXT] Re: [v4, 1/2] common/cnxk: add telemetry endpoints to npa

Gowrishankar Muthukrishnan gmuthukrishn at marvell.com
Fri Aug 27 08:43:46 CEST 2021


> >  includes += include_directories('../../bus/pci')
> >  includes += include_directories('../../../lib/net')
> > +includes += include_directories('../../../lib/telemetry')
> 
> Rather than giving the include directories, I'd recommend using "deps"
> variable to specify a direct dependency on those libraries. This should probably
> be:
> 
> deps += ['bus_pci', 'net', 'telemetry']
> 
> Using these as dependencies means that the header paths will be added
> automatically, and the libraries linked against too if any functions from those
> are used by the code in this lib.
> 

Ack. Thanks Bruce.

Regards,
Gowrishankar
> Regards,
> /Bruce


More information about the dev mailing list