[dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs

[Zhang, Roy Fan]

Hi Akhil

> -----Original Message-----
> From: Akhil Goyal <gakhil at marvell.com>
> Sent: Tuesday, August 31, 2021 8:04 AM
> To: Zhang, Roy Fan <roy.fan.zhang at intel.com>; Matan Azrad
> <matan at nvidia.com>; dev at dpdk.org
> Cc: Anoob Joseph <anoobj at marvell.com>; Nicolau, Radu
> <radu.nicolau at intel.com>; Doherty, Declan <declan.doherty at intel.com>;
> hemant.agrawal at nxp.com; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; NBU-Contact-Thomas Monjalon
> <thomas at monjalon.net>; asomalap at amd.com; ruifeng.wang at arm.com;
> ajit.khaparde at broadcom.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>;
> Ankur Dwivedi <adwivedi at marvell.com>; Michael Shamis
> <michaelsh at marvell.com>; Nagadheeraj Rottela
> <rnagadheeraj at marvell.com>; jianjay.zhou at huawei.com
> Subject: RE: [PATCH v2 3/4] examples/fips_validation: remove illegal usage of
> APIs
> 
> Hi Fan,
> > > > > Some of the cryptodev APIs are not allowed to be used by application
> > > > > directly. Hence removing the usage of 1. queue_pair_release: it is not
> > > > > required, as configure
> > > > >    of queue pair release the previous queue pairs and the
> > > > >    dev is not directly exposed to application, hence cannot
> > > > >    use its ops from app.
> > > > > 2. rte_cryptodev_stop: it can be used directly without
> > > > >    checking if the device is started or not.
> > > > > 3. rte_cryptodev_pmd_destroy: application should use
> > > > >    rte_cryptodev_close instead.
> > > > >
> > > > > Signed-off-by: Akhil Goyal <gakhil at marvell.com>
> > > >
> > > > Look's like it should be backported to stable releases with a Fixes
> > reference.
> > > > What do you think?
> > > >
> > > > Besides,
> > > > Acked-by: Matan Azrad <matan at nvidia.com>
> > > >
> > > Yes, Agreed.
> > > I wanted to get opinion from the Maintainer of fips app first if the
> changes
> > > are
> > > Correct or not.
> >
> > Hi Akhil,
> >
> > FIPS requirement is upon failure of running self-test the device memory
> > shall be destroyed completely and not visible by the application at all -
> > rte_cryptodev_close does not provide this functionality.
> >
> > In this case we may need new API rte_cryptodev_destroy() to replace
> > rte_cryptodev_pmd_destroy().
> >
> _create and _destroy are called from device probe and remove.
> If the requirement is to use pmd_destroy, how is the driver created again?
> I do not see the use of rte_cryptodev_pmd_create() function.
> 
> The use of pmd APIs is not allowed from the application and it looks
> something
> Is not correct here for the use of destroy API.
> Please check and fix as required.
> 
> Regards,
> Akhil

Will fix for Intel PMDs. 

Regards,
Fan