[PATCH v10 2/9] app/test: remove POSIX-specific code

[Dmitry Kozlyuk]

2021-12-01 10:43 (UTC-0800), Jie Zhou:
> - Remove header inclusion of netinet/in.h and terminos.h

Typo: "termios.h".

> - Include rte_os_shim.h
> - Replace sleep and usleep with rte_delay_us_sleep

Instead of all the above I'd say:
"Replace POSIX-specific code with DPDK equivalents
 or conditionally disable it on Windows."

> - Use NUL on Windows as /dev/null for Linux

"Linux" -> "Unix"

> - Exclude tests not supported on Windows yet, e.g. multi-process, and
>   IP address parsing (the test cases use linux netinet/in.h u6_addr
>   and better have a sperate patch to add such tests on Windows)

Instead of "e.g." a complete list of missing tests is preferable:
* multi-process
* PMD performance statistics display on signal
* command-line IP address parsing

TBH, I don't understand the issue with test_cmdline_ipaddr---
it could be fixed with just a few lines:

	#define IP4(a,b,c,d) {.s_addr = ... }

	#ifdef RTE_EXEC_ENV_WINDOWS
	#define s6_addr16 u.Word
	#else
	#define s6_addr16 __u6_addr.__u6_addr16
	#endif

Why it should be a separate patch?