[dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58

Bruce Richardson bruce.richardson at intel.com
Thu Jul 1 11:57:49 CEST 2021


On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote:
> On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote:
> > The `doc` target used `echo` as its command.
> > On Windows, `echo` is always a shell built-in, there is no binary.
> > Starting from meson 0.58, `run_target()` always searches for command
> > executable and no longer accepts `echo` as such on Windows.
> > Replace plain `echo` with a Python one-liner.
> > 
> > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson")
> > Cc: Bruce Richardson <bruce.richardson at intel.com>
> > Cc: Luca Boccassi <bluca at debian.org>
> > Cc: stable at dpdk.org
> > 
> > Reported-by: Rob Scheepens <rob.scheepens at nutanix.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> > ---
> 
> Acked-by: Luca Boccassi <bluca at debian.org>

One small suggestion might be to move the "echo" command definition to
buildtools folder in case it's wanted for use anywhere in the build at some
point in the future. However, this patch is fine without that change too.

Acked-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the dev mailing list