[dpdk-dev] [PATCH v2 08/58] net/bnxt: add action SRAM translation

[Ajit Khaparde]

On Mon, Jul 5, 2021 at 2:24 PM Thomas Monjalon <thomas at monjalon.net> wrote:

> 13/06/2021 02:06, Ajit Khaparde:
> > From: Farah Smith <farah.smith at broadcom.com>
> >
> > - Translate Truflow action types for Thor to HCAPI RM
> >   resource defined SRAM banks.
> > - move module type enum definitions to tf_core API
> > - Switch to subtype concept for RM.
> > - alloc/free working for Thor SRAM table type for full AR.
> >
> > Signed-off-by: Farah Smith <farah.smith at broadcom.com>
> > Signed-off-by: Randy Schacher <stuart.schacher at broadcom.com>
> > Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru at broadcom.com>
> > Reviewed-by: Peter Spreadborough <peter.spreadborough at broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> [...]
>
> I see 2 issues in the beginning of this patch:
>
> > --- a/drivers/net/bnxt/hcapi/cfa/hcapi_cfa.h
> > +++ b/drivers/net/bnxt/hcapi/cfa/hcapi_cfa.h
> > @@ -1,281 +1,126 @@
> > -/* SPDX-License-Identifier: BSD-3-Clause
> > - * Copyright(c) 2019-2021 Broadcom
> > - * All rights reserved.
> > +/*
> > + *   Copyright(c) Broadcom Limited.
> > + *   All rights reserved.
> >   */
>
> SPDX copyright is removed.
>
> >
> > +/*!
> > + *   \file
> > + *   \brief Exported functions for CFA HW programming
> > + */
> >  #ifndef _HCAPI_CFA_H_
> >  #define _HCAPI_CFA_H_
> >
> >  #include <stdio.h>
> > +#include <stddef.h>
> >  #include <string.h>
> >  #include <stdbool.h>
> >  #include <stdint.h>
> >  #include <stddef.h>
> > +#include <errno.h>
>
> stddef.h is included twice.
>
> Please fix in next-net-brcm, thanks.
>
Done.
Updated patch merged in dpdk-next-net-brcm. Thanks