[dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations

[Andrew Rybchenko]

On 7/8/21 9:09 AM, Jiawen Wu wrote:
> On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
>> On 7/6/21 12:55 PM, Jiawen Wu wrote:
>>> Setup MSI-X interrupt, complete PHY configuration and set device link
>>> speed to start device. Disable interrupt, stop hardware and clear
>>> queues to stop device.
>>>
>>> Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
>>
>> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see
>> Documentation/timers/timers-howto.rst
>> #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70:
>> +                       msleep(1);
>>
>> Any comments?
>>
> 
> This depends on the design of the hardware.

Isn't is a problem if sleep will be longer in fact?