[dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison

[Burakov, Anatoly]

On 09-Jul-21 2:46 PM, Thomas Monjalon wrote:
> 08/07/2021 16:13, Anatoly Burakov:
>>   doc/guides/rel_notes/release_21_08.rst        |  2 ++
>>   drivers/event/dlb2/dlb2.c                     | 17 ++++++++--
>>   drivers/net/i40e/i40e_rxtx.c                  | 20 +++++++----
>>   drivers/net/iavf/iavf_rxtx.c                  | 20 +++++++----
>>   drivers/net/ice/ice_rxtx.c                    | 20 +++++++----
>>   drivers/net/ixgbe/ixgbe_rxtx.c                | 20 +++++++----
>>   drivers/net/mlx5/mlx5_rx.c                    | 17 ++++++++--
>>   .../include/generic/rte_power_intrinsics.h    | 33 +++++++++++++++----
>>   lib/eal/x86/rte_power_intrinsics.c            | 17 +++++-----
>>   9 files changed, 122 insertions(+), 44 deletions(-)
> 
> About the title, it is introducing a new prefix "power_intrinsics:"
> with is not so much descriptive.
> Probably better to formulate with "eal:" prefix.


> 
> 
>> --- a/drivers/net/mlx5/mlx5_rx.c
>> +++ b/drivers/net/mlx5/mlx5_rx.c
>> @@ -269,6 +269,18 @@ mlx5_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
>>   	return rx_queue_count(rxq);
>>   }
>>   
>> +#define CLB_VAL_IDX 0
>> +#define CLB_MSK_IDX 1
>> +static int
>> +mlx_monitor_callback(const uint64_t value,
>> +		const uint64_t opaque[RTE_POWER_MONITOR_OPAQUE_SZ])
> 
> Everything is prefixed with mlx5, let's be consistent.
> Please replace mlx_ with mlx5_
> 

Sure, will fix.

-- 
Thanks,
Anatoly